-
Notifications
You must be signed in to change notification settings - Fork 698
Add SIGNER_APPROVAL_THRESHOLD env var for lowering threshold on testnet #6375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add SIGNER_APPROVAL_THRESHOLD env var for lowering threshold on testnet #6375
Conversation
Signed-off-by: Jacinta Ferrant <[email protected]>
testing a 3 miner/signer network with this env var set panics (see below).
|
i'm not sure here why |
… into feat/signer-approval-threshold-option
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Was an accidental != vs == I think. Hopefully that is the only spot. Give it a go now and let me know how it goes :D |
Closes #6368
Originally did this as two configuration options. One in signer, one in node. but it ended up touching more than 40 diff files in a very janky way. Even this change required more modifications than I would like, but I think its better.