Skip to content

Commit 25cf5a2

Browse files
author
meorphis
committed
Merge remote-tracking branch 'origin/main' into internal
2 parents 9e170cd + 202724b commit 25cf5a2

File tree

4 files changed

+13
-8
lines changed

4 files changed

+13
-8
lines changed

dist/build.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/merge.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/preview.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/outcomes.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,14 @@ export function categorizeOutcome({
252252
.filter((r): r is Exclude<typeof categoryOutcome, null> => r !== null)
253253
.sort(
254254
(a, b) =>
255-
// sort by severity then rank
255+
// sort by regression status then severity then rank
256+
(!(a.severity === "fatal" || b.severity === "fatal")
257+
? [true, null, false].indexOf(a.isRegression) -
258+
[true, null, false].indexOf(b.isRegression)
259+
: 0) ||
256260
conclusions.diagnostic.indexOf(a.severity) -
257-
conclusions.diagnostic.indexOf(b.severity) || a.rank - b.rank,
261+
conclusions.diagnostic.indexOf(b.severity) ||
262+
a.rank - b.rank,
258263
)[0];
259264

260265
return {

0 commit comments

Comments
 (0)