added reloader-enterprise dependency#1186
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a Helm chart “v2” packaging flow and adds an optional reloader-enterprise subchart dependency to support an enterprise deployment mode alongside the operator.
Changes:
- Updates the Helm chart metadata (apiVersion v2, chart/app versions) and adds an
enterprisedependency gated byenterprise.enabled. - Adds Enterprise-mode values/docs plus a Helm-unittest suite for image override behavior.
- Adjusts GitHub Actions workflows for v2 image tagging and v2 chart release/publish tagging conventions.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| deployments/kubernetes/chart/reloader/values.yaml | Adds enterprise-related global and subchart values; bumps default operator tag to v2.0.0. |
| deployments/kubernetes/chart/reloader/tests/enterprise_test.yaml | Adds a helm-unittest suite intended to validate image selection behavior. |
| deployments/kubernetes/chart/reloader/README.md | Documents “Enterprise mode” setup steps (enable subchart, set hosts, swap image, provide pull secret). |
| deployments/kubernetes/chart/reloader/Chart.yaml | Moves to Helm v2 chart format, renames chart to reloader-v2, and adds the reloader-enterprise dependency. |
| .github/workflows/release.yaml | Publishes a floating v2 image tag instead of latest for v2 releases. |
| .github/workflows/release-helm-chart.yaml | Updates chart release tagging/title to the new reloader-v2-chart-v* convention. |
| .github/workflows/push-helm-chart.yaml | Updates publish flow for reloader-v2, adds helm dependency build, and updates signing/tagging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| apiVersion: v2 | ||
| name: reloader-v2 | ||
| description: Reloader chart that runs on kubernetes | ||
| version: 2.2.12 | ||
| appVersion: v1.4.17 | ||
| version: 2.0.0 | ||
| appVersion: v2.0.0 |
There was a problem hiding this comment.
helm-version-validation still targets the old chart name and will fail the gate
| 2. Swap the operator image to the enterprise image: | ||
|
|
||
| ```yaml | ||
| image: | ||
| repository: ghcr.io/stakater/reloader-enterprise | ||
| tag: v0.1.0 | ||
| ``` |
SyedaFatimaKazmi
left a comment
SyedaFatimaKazmi
left a comment
There was a problem hiding this comment.
also pls note that the private subchart gets bundled into the public chart package
if the enterprise chart templates are considered private IP, bundling them into a publicly pullable OCI artifact leaks them (only the images stay gated behind pull secrets)
please confirm this is intended
| apiVersion: v2 | ||
| name: reloader-v2 | ||
| description: Reloader chart that runs on kubernetes | ||
| version: 2.2.12 | ||
| appVersion: v1.4.17 | ||
| version: 2.0.0 | ||
| appVersion: v2.0.0 |
There was a problem hiding this comment.
helm-version-validation still targets the old chart name and will fail the gate
| gatewayHost: reloader-enterprise-gateway.apps.example.com | ||
| ``` | ||
|
|
||
| 2. Swap the operator image to the enterprise image: |
There was a problem hiding this comment.
we can consider adding a {{ fail }} guard when enterprise.enabled=true and the image still points at the community repo, mirroring the namespace-validation guard added in #1184
| ```yaml | ||
| image: | ||
| repository: ghcr.io/stakater/reloader-enterprise | ||
| tag: v0.1.0 |
There was a problem hiding this comment.
nit: here the enterprise image.tag is v0.1.0, but enterprise_test.yaml uses v2.0.0 and the dependency chart version is 0.1.0
three different-looking versions - we should perhaps clarify chart-version vs image-tag so users don't copy the wrong one
No description provided.