fix: self-contained release binaries (libprofiler + Windows DLLs)#13
Merged
Conversation
Release binaries dynamically linked the system shared libprofiler/libtcmalloc
whenever gperftools was present on the build machine. The self-hosted Linux
release runner has libgoogle-perftools-dev installed, so the shipped v0.6.0
binary hard-depended on libprofiler.so.0 and failed to load on any machine
without gperftools:
error while loading shared libraries: libprofiler.so.0: cannot open
shared object file: No such file or directory
gperftools is a dev-only profiling aid (--profile-cpu / --profile-memory).
Gate it behind LCI_ENABLE_GPERFTOOLS (default OFF) so release builds never
link it; profiling.cpp already fails fast at runtime with a rebuild hint when
absent. Opting in but missing gperftools now hard-errors at configure time
instead of silently skipping.
Verified on a machine WITH libprofiler.so.0 installed: release `lci` NEEDED
list no longer contains profiler/tcmalloc — only universal system libs.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…md triplet The Windows release leg configured vcpkg with the default x64-windows triplet, which builds the manifest deps (abseil, re2, xxhash, ...) as DLLs. The CPack TGZ ships only lci.exe, so the shipped binary references absl_*.dll / re2.dll that are absent on any machine without the build tree — the Windows analogue of the libprofiler.so.0 load failure. The unit gate passed regardless because the DLLs sit next to the test exe in the build tree, so CI was green while the tarball was broken. Pin VCPKG_TARGET_TRIPLET=x64-windows-static-md on both the release and ci windows legs (kept in lockstep so the gate exercises the shipped linkage). That triplet links the vcpkg deps statically into lci.exe while keeping the dynamic CRT (/MD) the project and its FetchContent deps already use, avoiding a CRT mismatch. Verified the triplet exists at the pinned vcpkg commit (f3e1065) and resolves to CRT=dynamic, LIBRARY=static. BUILD_SHARED_LIBS=OFF only governs the FetchContent deps; vcpkg packages follow the triplet, which is why Linux (x64-linux) and macOS (arm64-osx) were already self-contained (static by default) and only Windows leaked DLLs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The published v0.6.0 binary failed to load on clean machines:
And the Windows/macOS release legs (added one day after v0.6.0 tagged) have never shipped a working artifact. Two distinct "green CI, broken tarball" defects — the dep sits in the build tree next to the test exe, so
lci_testspasses while the shippedbin/lcireferences libs that aren't bundled.Fixes
gperftools opt-in (
src/CMakeLists.txt) — release auto-linked the system sharedlibprofiler/libtcmallocwhenever present on the build machine. Now gated behindLCI_ENABLE_GPERFTOOLS(default OFF).profiling.cppalready fails fast at runtime when absent. Verified: releaselciNEEDED no longer lists profiler/tcmalloc (on a machine that has libprofiler installed). Fixes Linux and the macOS brew-libprofiler analogue.Windows static-md triplet (
ci.yml+release.yml) — Windows configured vcpkg with the defaultx64-windowstriplet → abseil/re2 built as DLLs, not bundled by CPack. PinVCPKG_TARGET_TRIPLET=x64-windows-static-mdon both legs (lockstep, so the gate exercises the shipped linkage). Static libs + dynamic CRT (/MD) matches the project/FetchContent default — no CRT mismatch.Why only Windows leaked
BUILD_SHARED_LIBS=OFFgoverns only the FetchContent deps; vcpkg packages follow the triplet. Linuxx64-linuxand macOSarm64-osxare static-by-default, so only Windows defaulted to dynamic DLLs.Verification
lciv0.7.0 NEEDED: no profiler/tcmalloc, only universal system libs.re2:x64-windows→ 2 DLLs (abseil_dll.dll,re2.dll);re2:x64-windows-static-md→ 0 DLLs. Triplet forcesLIBRARY=staticfor all manifest deps.🤖 Generated with Claude Code