Make host:port for tracer configurable#161
Open
halseth wants to merge 2 commits intostarkware-libs:masterfrom
Open
Make host:port for tracer configurable#161halseth wants to merge 2 commits intostarkware-libs:masterfrom
halseth wants to merge 2 commits intostarkware-libs:masterfrom
Conversation
We make --host and --port new CLI arguments, such that they can be specified at startup. To ensure backwards compatibility, we default to the previous values localhost:8100 if the flags are not provided.
halseth
force-pushed
the
tracer-argument
branch
from
b63bbc8 to
f61a133
Compare
We make the --tracer flag take an optional argument, letting us configure the host:port to serve on at startup. We default to localhost:8100 if the optional argument is not set, and as previously don't start the tracer in case the --tracer flag is not set at all.
halseth
force-pushed
the
tracer-argument
branch
from
f61a133 to
d0b9cc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful especially when running inside containers.
Usage:
Fixes #126
This change is