Skip to content

Fix signature.cairo is not compiling due to type mismatch #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix signature.cairo is not compiling due to type mismatch #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/starkware/cairo/common/cairo_secp/signature.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,9 @@ func is_on_curve{range_check_ptr}(x: BigInt3, y: BigInt3) -> (res: felt) {
d0=x_cube.d0 + BETA - y_square.d0, d1=x_cube.d1 - y_square.d1, d2=x_cube.d2 - y_square.d2
);

let (reduced_diff) = reduce(diff);

return is_zero(reduced_diff);
reduce(diff);
call is_zero;
ret;
}

// Returns a point on the secp256k1 curve with the given x coordinate. Chooses the y that has the
Expand Down