optimized sha256_bytearray

[TomerStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[TomerStarkware]

• optimized sha256_bytearray #8322 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[orizi]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @giladchase)

---

corelib/src/sha256.cairo line 86 at r1 (raw file):

/// ```
pub fn compute_sha256_byte_array(arr: @ByteArray) -> [u32; 8] {
    let mut span = Span { snapshot: arr.data };

Suggestion:

    let mut span = arr.data.span();

---

corelib/src/sha256.cairo line 90 at r1 (raw file):

    let mut words_arr = array![];
    let mut last_word = 0;
    let mut last_word_len = 0;

Suggestion:

    let mut last_word_len: BoundedInt::<0, 3> = 0;

---

corelib/src/sha256.cairo line 102 at r1 (raw file):

        let mut shift = *arr.pending_word_len - BYTES_IN_U128 + last_word_len;
        if shift >= 4 {
            shift = shift - 4;

Suggestion:

        let mut shift = *arr.pending_word_len - BYTES_IN_U128 + last_word_len;
        if let Some(shift) = shift.checked_sub(4) {