refactor(byte_array): hoist test utils #8328
Conversation
|
This change is |
Just MOVE, no inner changes.
There was a problem hiding this comment.
@TomerStarkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @orizi)
There was a problem hiding this comment.
@orizi reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)
corelib/src/test/byte_array_test.cairo line 5 at r1 (raw file):
// ========= Test-utils ========= fn compare_byte_array(
all of this can probably just be replaced with assert_eq! and using printable strings:
(substring of `abcdefghi...ABCD..0..9)
giladchase
force-pushed
the
gilad/09-03-refactor_byte_array_hoist_test_utils
branch
from
07a2911 to
fa5fc99
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
corelib/src/test/byte_array_test.cairo line 5 at r1 (raw file):
Previously, orizi wrote…
all of this can probably just be replaced with
assert_eq!and using printable strings:
(substring of `abcdefghi...ABCD..0..9)
Added to the other stack, closing this one.
giladchase
deleted the
gilad/09-03-refactor_byte_array_hoist_test_utils
branch
Just MOVE, no inner changes.