refactor(test): remove fixed-size bytearray testutils

[giladchase]

It's legacy.

[reviewable-StarkWare]

This change is 

[giladchase]

• feat(ops): add get, SliceIndex and impl for ByteSpan #8417 : 2 dependent PRs (#8427 , #8511 )
• feat(byte_array): add ByteSpan::to_byte_array #8416
• refactor(byte_array): extract ByteArray::append logic #8486
• feat(byte_array): add ByteArray::span and Span::len #8329
• refactor(test): remove fixed-size bytearray testutils #8343 👈 (View in Graphite)
• refactor(test): remove compare_spans util #8342
• refactor(test): remove compare_byte_array util and rework tests #8336
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[orizi]

@orizi reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

---

corelib/src/test/byte_array_test.cairo line 320 at r1 (raw file):

    let byte_array: ByteArray = "a";
    assert_eq!(@byte_array, @"a", "Same strings are not equal");
    assert_ne!(@byte_array, @"b", "Different strings are equal");

all around.

Suggestion:

    assert_eq!(byte_array, "a", "Same strings are not equal");
    assert_ne!(byte_array, "b", "Different strings are equal");

[giladchase]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)

---

corelib/src/test/byte_array_test.cairo line 320 at r1 (raw file):

Previously, orizi wrote…

all around.

Done.

[orizi]

@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[TomerStarkware]

@TomerStarkware reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

[graphite-app]

Merge activity

• Sep 4, 11:02 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.