Make file_syntax_data function public

[wawel37]

1. We make it public as we need it in the cairo-lint and LS.
2. We change the type to dyn Database, as we want to use this struct in LS, where we use the Database type from salsa already

[reviewable-StarkWare]

This change is 

[orizi]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion

---

crates/cairo-lang-parser/src/db.rs line 53 at r1 (raw file):

/// Parses a file and returns the result and the generated [ParserDiagnostic].
#[salsa::tracked(returns(ref))]
pub fn file_syntax_data<'db>(db: &'db dyn Database, file_id: FileId<'db>) -> SyntaxData<'db> {

you don't need it - you have all the members of ParserGroup as the selectors for this data struct.

[wawel37]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-parser/src/db.rs line 53 at r1 (raw file):

Previously, orizi wrote…

you don't need it - you have all the members of ParserGroup as the selectors for this data struct.

Ok, so cant we just make the syntax_file function part of the query group? As it's used in existing selectors anyway. And we don't want to duplicate logic of choosing right selector based on the FileId kind

[orizi]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @wawel37)

---

crates/cairo-lang-parser/src/db.rs line 53 at r1 (raw file):

Previously, wawel37 (Mateusz Kowalski) wrote…

Ok, so cant we just make the syntax_file function part of the query group? As it's used in existing selectors anyway. And we don't want to duplicate logic of choosing right selector based on the FileId kind

i still don't see WHY you need it - what is the actual context?