Skip to content

Conversation

FroyaTheHen
Copy link
Collaborator

@FroyaTheHen FroyaTheHen commented Oct 2, 2025

@reviewable-StarkWare
Copy link

This change is Reviewable

@FroyaTheHen FroyaTheHen self-assigned this Oct 2, 2025
@FroyaTheHen FroyaTheHen requested review from Arcticae and orizi October 2, 2025 13:36
@FroyaTheHen FroyaTheHen marked this pull request as ready for review October 2, 2025 13:54
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Arcticae)


crates/cairo-lang-doc/src/signature_data.rs line 244 at r1 (raw file):

        .filter(|param| !trait_params_set.contains(param))
        .cloned()
        .collect_vec();

doc the change here - i don't understand it at all.

Code quote:

    let trait_id = item_id.trait_id(db);
    let trait_resolver_data = trait_id
        .resolver_data(db)
        .map_err(|_| SignatureError::FailedRetrievingSemanticData(item_id.full_path(db)))?;
    let trait_params_set: HashSet<_> = trait_resolver_data.generic_params.iter().collect();

    let function_generic_params: Vec<GenericParamId<'_>> = resolver_data
        .generic_params
        .iter()
        .filter(|param| !trait_params_set.contains(param))
        .cloned()
        .collect_vec();

Copy link
Collaborator Author

@FroyaTheHen FroyaTheHen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Arcticae and @orizi)


crates/cairo-lang-doc/src/signature_data.rs line 244 at r1 (raw file):

Previously, orizi wrote…

doc the change here - i don't understand it at all.

Done.

Copy link
Collaborator

@Arcticae Arcticae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Arcticae reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @FroyaTheHen and @orizi)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @FroyaTheHen)

@FroyaTheHen FroyaTheHen added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit 131cb4c Oct 7, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scarb doc fix duplicated trait function generics

4 participants