-
Notifications
You must be signed in to change notification settings - Fork 628
fix trait function generic params in doc signature #8496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Arcticae)
crates/cairo-lang-doc/src/signature_data.rs
line 244 at r1 (raw file):
.filter(|param| !trait_params_set.contains(param)) .cloned() .collect_vec();
doc the change here - i don't understand it at all.
Code quote:
let trait_id = item_id.trait_id(db);
let trait_resolver_data = trait_id
.resolver_data(db)
.map_err(|_| SignatureError::FailedRetrievingSemanticData(item_id.full_path(db)))?;
let trait_params_set: HashSet<_> = trait_resolver_data.generic_params.iter().collect();
let function_generic_params: Vec<GenericParamId<'_>> = resolver_data
.generic_params
.iter()
.filter(|param| !trait_params_set.contains(param))
.cloned()
.collect_vec();
commit-id:faf3c30e
295a0bc
to
8765607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Arcticae and @orizi)
crates/cairo-lang-doc/src/signature_data.rs
line 244 at r1 (raw file):
Previously, orizi wrote…
doc the change here - i don't understand it at all.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arcticae reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @FroyaTheHen and @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @FroyaTheHen)
closes software-mansion/scarb#2649