Skip to content

Remove redundant clone in cairo-lang-test-plugin #8601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −6
Open

Remove redundant clone in cairo-lang-test-plugin #8601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f23feb6
Update lib.rs
Doryu001 Nov 3, 2025
b9e0a90
Update lib.rs
Doryu001 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/cairo-lang-test-plugin/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
use std::default::Default;

use anyhow::{Result, ensure};
use cairo_lang_compiler::diagnostics::DiagnosticsReporter;
use cairo_lang_compiler::{ensure_diagnostics, get_sierra_program_for_functions};
Expand Down Expand Up @@ -145,8 +143,8 @@ pub fn compile_test_prepared_db<'db>(
)
.collect();

let SierraProgramWithDebug { program: sierra_program, debug_info } =
get_sierra_program_for_functions(db, func_ids)?;
let SierraProgramWithDebug { program: mut sierra_program, debug_info } =
get_sierra_program_for_functions(db, func_ids)?.clone();

let function_set_costs: OrderedHashMap<FunctionId, CostTokenMap<i32>> = all_entry_points
.iter()
Expand All @@ -159,13 +157,14 @@ pub fn compile_test_prepared_db<'db>(
.collect();

let replacer = DebugReplacer { db };
let mut sierra_program = sierra_program.clone();
replacer.enrich_function_names(&mut sierra_program);

let mut annotations = Annotations::default();
if tests_compilation_config.add_statements_functions {
annotations.extend(Annotations::from(
debug_info.statements_locations.extract_statements_functions(db),
debug_info
.statements_locations
.extract_statements_source_code_locations(db),
))
}
if tests_compilation_config.add_statements_code_locations {
Expand Down