starknet_os: move starknet os config outside of block_context #9489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Yoni-Starkware
requested changes
Oct 5, 2025
There was a problem hiding this comment.
@Yoni-Starkware reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/block_context.cairo line 89 at r1 (raw file):
sequencer_address=0, ), starknet_os_config=starknet_os_config,
Keep it without the * in the block context struct, to make the access to chain_id and fee_token_address cheaper
Suggestion:
starknet_os_config=[starknet_os_config],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.