starknet_committer,starknet_committer_cli: move TimeMesaurment to the committer crate #9505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 5, 2025
|
Benchmark movements: No major performance changes detected. |
TzahiTaub
force-pushed
the
yoav/committer_benchmark/mdbx_playground
branch
from
795c122 to
e2adee5
Compare
TzahiTaub
force-pushed
the
09-30-starknet_committer_starknet_committer_cli_move_timemesaurment_to_the_committer_crate_to_allow_inner_calls_benchmarking
branch
from
c7bef91 to
26fda47
Compare
TzahiTaub
changed the title
TzahiTaub
requested review from
dorimedini-starkware
and removed request for
dorimedini-starkware
dorimedini-starkware
approved these changes
Oct 5, 2025
There was a problem hiding this comment.
@dorimedini-starkware reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)
TzahiTaub
force-pushed
the
09-30-starknet_committer_starknet_committer_cli_move_timemesaurment_to_the_committer_crate_to_allow_inner_calls_benchmarking
branch
from
26fda47 to
3f68836
Compare
TzahiTaub
force-pushed
the
yoav/committer_benchmark/mdbx_playground
branch
from
e2adee5 to
3a6490f
Compare
TzahiTaub
changed the base branch from
yoav/committer_benchmark/mdbx_playground
to
committer_storage_benchmark
… committer crate To allow inner calls benchmarking
TzahiTaub
force-pushed
the
09-30-starknet_committer_starknet_committer_cli_move_timemesaurment_to_the_committer_crate_to_allow_inner_calls_benchmarking
branch
from
3f68836 to
08e973e
Compare
TzahiTaub
commented
Oct 5, 2025
There was a problem hiding this comment.
@TzahiTaub reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow inner calls benchmarking