-
Notifications
You must be signed in to change notification settings - Fork 64
starknet_os_flow_tests: migrate test_initial_sierra_gas #9539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 10-08-starknet_os_flow_tests_migrate_test_block_info
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
crates/starknet_os_flow_tests/src/tests.rs
line 2231 at r1 (raw file):
// L1 handler bounds test. let expected_l1_handler_gas_upper_bound = os_constants.l1_handler_max_amount_bounds.l2_gas.0; let expected_l1_handler_gas_lower_bound = expected_l1_handler_gas_upper_bound - 10001;
the original test subtracts exactly 10K, but it fails here, as the get_available_gas
returns exactly 99990000, any ideas why? @meship-starkware
Code quote:
expected_l1_handler_gas_upper_bound - 10001;
8a1fdf8
to
2787132
Compare
01b2f9d
to
c3db116
Compare
2787132
to
492b9c7
Compare
c3db116
to
3ed646c
Compare
492b9c7
to
6a5be89
Compare
3ed646c
to
57c0e9e
Compare
6a5be89
to
3050ce8
Compare
57c0e9e
to
cc9b30a
Compare
3050ce8
to
d26bb4a
Compare
cc9b30a
to
8a6fcbe
Compare
d26bb4a
to
d0d082f
Compare
8a6fcbe
to
aa87259
Compare
d0d082f
to
430313a
Compare
aa87259
to
4341e7a
Compare
430313a
to
f078eb7
Compare
4341e7a
to
9a3c4a5
Compare
f078eb7
to
f43be73
Compare
9a3c4a5
to
75c61ac
Compare
f43be73
to
99a85f2
Compare
75c61ac
to
589c478
Compare
99a85f2
to
b1c83fc
Compare
589c478
to
6d1de2a
Compare
b1c83fc
to
6e2959d
Compare
6d1de2a
to
cf08493
Compare
6e2959d
to
1bae756
Compare
cf08493
to
b91d4e0
Compare
No description provided.