Skip to content

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 9, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)


crates/starknet_os_flow_tests/src/tests.rs line 2231 at r1 (raw file):

    // L1 handler bounds test.
    let expected_l1_handler_gas_upper_bound = os_constants.l1_handler_max_amount_bounds.l2_gas.0;
    let expected_l1_handler_gas_lower_bound = expected_l1_handler_gas_upper_bound - 10001;

the original test subtracts exactly 10K, but it fails here, as the get_available_gas returns exactly 99990000, any ideas why? @meship-starkware

Code quote:

expected_l1_handler_gas_upper_bound - 10001;

@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 8a1fdf8 to 2787132 Compare October 9, 2025 09:39
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 01b2f9d to c3db116 Compare October 9, 2025 09:39
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 2787132 to 492b9c7 Compare October 9, 2025 09:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from c3db116 to 3ed646c Compare October 9, 2025 09:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 492b9c7 to 6a5be89 Compare October 9, 2025 11:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 3ed646c to 57c0e9e Compare October 9, 2025 11:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 6a5be89 to 3050ce8 Compare October 9, 2025 11:47
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 57c0e9e to cc9b30a Compare October 9, 2025 11:47
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 3050ce8 to d26bb4a Compare October 9, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from cc9b30a to 8a6fcbe Compare October 9, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from d26bb4a to d0d082f Compare October 9, 2025 13:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 8a6fcbe to aa87259 Compare October 9, 2025 13:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from d0d082f to 430313a Compare October 9, 2025 13:32
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from aa87259 to 4341e7a Compare October 9, 2025 13:32
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 430313a to f078eb7 Compare October 9, 2025 14:20
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 4341e7a to 9a3c4a5 Compare October 9, 2025 14:20
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from f078eb7 to f43be73 Compare October 9, 2025 15:25
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 9a3c4a5 to 75c61ac Compare October 9, 2025 15:25
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from f43be73 to 99a85f2 Compare October 9, 2025 17:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 75c61ac to 589c478 Compare October 9, 2025 17:06
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 99a85f2 to b1c83fc Compare October 14, 2025 10:23
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 589c478 to 6d1de2a Compare October 14, 2025 10:24
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from b1c83fc to 6e2959d Compare October 14, 2025 10:36
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 6d1de2a to cf08493 Compare October 14, 2025 10:36
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 6e2959d to 1bae756 Compare October 15, 2025 11:23
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from cf08493 to b91d4e0 Compare October 15, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants