Helpers

[tcash21]

@Btibert3 This is so awesome. Any tests I should run in particular? I'll probably run a bunch of basic scripts I have for each sport and then vote to merge.

[Btibert3]

@tcash21 I would run through your code base or some of the recipes that you run often. That said, I noticed that on my older work machine I was hitting an error on some of the sport-specific helpers which I hadn't encountered before. Any and all things that you can think of. It's pretty solid (methinks), but as we keep stacking on top of the core functions, the dependencies are growing. Throw whatever you can at it, and I will look at the sport helpers tonight and start to think about a better test suite.

For future reference, this is the error I had thrown on the basic teams call

 > mlb <- hockey_teams()
[1] "Making initial API request"
Joining by: "league_id"
Error: No common variables. Please specify `by` param.

[Btibert3]

There was a simple bug in the join on the *_teams helper when we join divisions and conference side-loaded data.

[tcash21]

Any reason to not just have the user use select in dplyr instead of our own custom ss_keep_cols?

[Btibert3]

The ability to control for invalid columns specified by the user.

On Sun, May 22, 2016 at 8:21 PM, tcash21 notifications@github.com wrote:

Any reason to not just have the user use select in dplyr instead of our
own custom ss_keep_cols?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#32 (comment)