This repository was archived by the owner on Jul 22, 2026. It is now read-only.

feat: Update the enable-notifications flows and notification settings UI - #22524

Merged

seanstrom merged 31 commits into

developfrom

seanstrom/news-notifications-ui

May 19, 2025

Commits on May 19, 2025

fix: ensure we always save the notifications-enabled setting when changed
seanstrom
committed
779355a
feat: implement the push-notification-disabled banner
seanstrom
committed
b8d12b9
wip: adjust enable-notifications screen and flows
seanstrom
committed
8f6a803
wip: adjust notification settings screen with nested ui
seanstrom
committed
0273a1f
chore: clean up translations for onboarding
seanstrom
committed
4c0c9af
chore: cleanup notifications settings screen
seanstrom
committed
18bc5da
fix: ensure we use the correct customization color when during onboarding or login when displaying the enable-notifications screen
seanstrom
committed
205d3a4
fix: ensure we use the default customization colour when onboarding profile color does not exist
seanstrom
committed
cd4a61a
fix: ensure we navigate to the notifications setup screen from any screen during onboarding or login
seanstrom
committed
ef2d132
fix: ensure the third-party checkbox only defaults to true when the news-notifications feature flag is active
seanstrom
committed
f254fa0
fix: add deps array to use-callback in enable-notifications screen
seanstrom
committed
eea665b
fix: feature-flag the enable-notifications screen
seanstrom
committed
b1d2727
chore: mark unused variable with underscore
seanstrom
committed
5035f1a
chore: remove empty wrapper view
seanstrom
committed
e585136
fix: ensure we have reader-conditionals for release builds
seanstrom
committed
8ba6578
chore: update google-services plist for ios release
seanstrom
committed
fc6326e
chore: refactor kv_storage events, effects, and interceptors
seanstrom
committed
5ae114b
chore: cleanup view-id access
seanstrom
committed
8a53015
chore: cleanup subscription
seanstrom
committed
a7cbcfa
chore: revise cond to if expression
seanstrom
committed
51a73b0
chore: use boolean? function instead of if-expression
seanstrom
committed
9cb5928
fix: use customization color for checkbox
seanstrom
committed
64adafb
chore: use rn/stylesheet-absolute-fill
seanstrom
committed
2c477ad
chore: inline event handlers
seanstrom
committed
a32f148
chore: simplify cond-expression to if-expression
seanstrom
committed
44a9533
fix: ensure we finalize notification setup when syncing during onboarding
seanstrom
committed
a2735f2
chore: remove unneeded key-uid
seanstrom
committed
4ea25cf
fix: ensure we disable the toggle
seanstrom
committed
00a3218
fix: ensure we retain the checked state when disabled
seanstrom
committed
2df1099
fix: ensure we register the event handlers correctly
seanstrom
committed
a66ca16
fix: ensure we use set-object
seanstrom
committed
a5bdf6e

Navigation Menu

Uh oh!

feat: Update the enable-notifications flows and notification settings UI - #22524

feat: Update the enable-notifications flows and notification settings UI#22524
seanstrom merged 31 commits into
developfrom
seanstrom/news-notifications-ui

Commits on May 19, 2025

fix: ensure we always save the notifications-enabled setting when changed

feat: implement the push-notification-disabled banner

wip: adjust enable-notifications screen and flows

wip: adjust notification settings screen with nested ui

chore: clean up translations for onboarding

chore: cleanup notifications settings screen

fix: ensure we use the correct customization color when during onboarding or login when displaying the enable-notifications screen

fix: ensure we use the default customization colour when onboarding profile color does not exist

fix: ensure we navigate to the notifications setup screen from any screen during onboarding or login

fix: ensure the third-party checkbox only defaults to true when the news-notifications feature flag is active

fix: add deps array to use-callback in enable-notifications screen

fix: feature-flag the enable-notifications screen

chore: mark unused variable with underscore

chore: remove empty wrapper view

fix: ensure we have reader-conditionals for release builds

chore: update google-services plist for ios release

chore: refactor kv_storage events, effects, and interceptors

chore: cleanup view-id access

chore: cleanup subscription

chore: revise cond to if expression

chore: use boolean? function instead of if-expression

fix: use customization color for checkbox

chore: use rn/stylesheet-absolute-fill

chore: inline event handlers

chore: simplify cond-expression to if-expression

fix: ensure we finalize notification setup when syncing during onboarding

chore: remove unneeded key-uid

fix: ensure we disable the toggle

fix: ensure we retain the checked state when disabled

fix: ensure we register the event handlers correctly

fix: ensure we use set-object