Fix misleading msvc macro and unreachable return in swap function#21
Open
rilysh wants to merge 1 commit intostbrumme:masterfrom
Open
Fix misleading msvc macro and unreachable return in swap function#21rilysh wants to merge 1 commit intostbrumme:masterfrom
rilysh wants to merge 1 commit intostbrumme:masterfrom
Conversation
KaruroChori
pushed a commit
to lazy-eggplant/hash-library
that referenced
this pull request
Sep 30, 2024
Apply fixes from stbrumme#20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR addresses the following issues.
swap(...)function has usedMSC_VERinstead of_MSC_VERwhich will lead them to fall back to the manual implementation of the byteswap(...)function.#elsefor the manual implementation (e.g. If the compiler doesn't have a built-in byte swap function), then the warning can be avoided.