fix: disable HTML escaping in JSON encoder to preserve transaction signatures#258
Merged
Conversation
…gnatures Go's json.Marshal escapes HTML special chars (<, >, \u0026) to \uXXXX by default. steemd's FC JSON parser does not understand \u escapes, so a transaction body containing '>' would be received as 'u003e', breaking the signature verification and causing 'Missing Posting Authority' errors. This only affects long posts/comments that contain these characters. Use json.Encoder with SetEscapeHTML(false) for both HTTP and WebSocket upstream requests. Fixes #258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Go's
json.Marshalescapes HTML special characters (<,>,&) to \uXXXX by default. steemd's FC JSON parser does not understand \u escapes, so a transaction body containing>(common in Markdown blockquotes) would be received asu003e, breaking the signature verification and causingMissing Posting Authorityerrors.This only affects long posts/comments that contain these characters. Short comments without HTML special chars are unaffected.
Root Cause
encoding/jsonescapes<→ \u003c,>→ \u003e,&→ \u0026parseEscape()doesn't support \uXXXX Unicode escapesu003e(5 chars) instead of>(1 char)Solution
helpers.MarshalJSONWithoutHTMLEscape()utility functionjson.EncoderwithSetEscapeHTML(false)for upstream request serializationEncoder.Encode()to matchjson.MarshalbehaviorFiles Changed
internal/helpers/json.go- New utility function with detailed commentsinternal/helpers/json_test.go- Unit tests (8 test cases)internal/upstream/http.go- HTTP client uses utility functioninternal/ws/client.go- WebSocket client uses utility functionTesting
Fixes #258