fix: disable memory cache when Redis is available to prevent TTL staleness#259
Merged
Merged
Conversation
…eness Redis→memory promotion in CacheGroup.Get/MGet passed TTL=0, causing entries like get_dynamic_global_properties (TTL=1s) to live indefinitely in the memory layer and serve stale block data to wallets, which then built transactions that expired before reaching steemd. Now memory cache is only created as a fallback when Redis is unreachable. The promotion TTL is also capped at 5s to prevent unbounded staleness in the edge case where both caches coexist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Redis is configured, disable the in-process memory cache to prevent stale TTL entries that cause LIB to appear stuck. The memory cache TTL was not being refreshed on Redis updates, leading to cached responses diverging from the actual chain state.