Repository navigation
Update Lean, mathlib, and Rocq - #846
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the proof toolchains:
lake-manifest.jsonchanges.rocq-core: 9.2.0 → 9.3.0rocq-stdlib: 9.1.0 → 9.2.0 (it supports Rocq 9.1–9.3)Rocq 9.3 adds or upgrades several warnings in the
defaultcategory. Since_RocqProjectpasses-w +default, they are errors here, so this PR fixes them:missing-proof-command: twoGoals intutorial/lesson5_consistency.vnow start withProof.at-level-200-changed: the tutorial'sexistsnotation intutorial/lesson3_logic.vnow usesat level 10, x binder, p at level 200(droppingright associativity), which matches how Rocq 9.3's prelude declares it.non-boolean-if: thesumboolguards (name_eq,eq_nat_dec) instlcandsystem_fnow useif ... is left _ then ... else .... This elaborates to the samematch. Arms that exceeded the 79-column limit are wrapped.I verified the Rocq build locally with
rocq/rocq-prover:9.3(9.3+rc1, stdlib 9.2.0): all 60 files compile with no warnings.rocq makefilenow prints a deprecation warning about omitting--rocq-package. It doesn't fail the build, so this PR leaves it alone.The copyright year in
LICENSE.mdis already current, and all GitHub Actions are already at their latest versions.Status: Ready