Skip to content

Conversation

burrbull
Copy link
Member

Part of #186

This PR reexport gpiox::Pxx in gpio and changes AFx to be more compatible with f4xx-hal.
This should make user code cleaner.

cc @usbalbin

@burrbull burrbull force-pushed the gpio-simplify branch 2 times, most recently from 13e3a2c to 4840114 Compare May 27, 2025 07:35
Copy link
Member

@usbalbin usbalbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@usbalbin
Copy link
Member

Would you mind rebasing this over the latest changes in main?

@usbalbin
Copy link
Member

Thanks!

@usbalbin
Copy link
Member

I just tested with cargo test --features stm32g474,defmt,cordic --tests -- --chip stm32g474RETx on a nucleo-g474 and all tests pass!
Awesome thank you!

I'll merge this now if that's ok?

@burrbull
Copy link
Member Author

Ok

@usbalbin usbalbin merged commit a77d7a4 into stm32-rs:main May 27, 2025
34 checks passed
@burrbull
Copy link
Member Author

Is there no "Merge queue" on this repository?

@burrbull burrbull deleted the gpio-simplify branch May 27, 2025 11:10
@usbalbin
Copy link
Member

Thanks for the tip. I think managed to add that now. I will try with #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants