Reduce Storyblok API non-Successful codes to HTTPExceptions#107
Open
llupa wants to merge 2 commits intostoryblok:1.xfrom
Open
Reduce Storyblok API non-Successful codes to HTTPExceptions#107llupa wants to merge 2 commits intostoryblok:1.xfrom
llupa wants to merge 2 commits intostoryblok:1.xfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #107 +/- ##
============================================
+ Coverage 94.57% 94.58% +0.01%
- Complexity 285 286 +1
============================================
Files 43 43
Lines 1069 1071 +2
============================================
+ Hits 1011 1013 +2
Misses 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OskarStark
reviewed
Mar 19, 2026
src/Controller/CdnController.php
Outdated
| $downloaded = $this->downloader->download($metadata->originalUrl); | ||
| try { | ||
| $downloaded = $this->downloader->download($metadata->originalUrl); | ||
| } catch (AssetDownloadFailedException $e) { |
Collaborator
There was a problem hiding this comment.
couldn't we add an attribute to the AssetDownloadFailedException to map it to the NotFoundHttpException?
Contributor
Author
There was a problem hiding this comment.
I can add but just to be sure, the bundle requires symfony/http-kernel: ^6.0. The #[WithHttpStatus] attribute was introduced in Symfony 6.3, so it does not work for people who have 6.0, 6.1, or 6.2.
Shall we bump the requirement or leave as is?
llupa
force-pushed
the
asset-download-failed-exception
branch
from
e7f694a to
eaf1c56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.