Repository navigation
Conversation
…format Problem: the Render Queue had no single-file uncompressed output, so handing a render to an external encoder meant a lossy codec, ProRes, or an image sequence plus a separate WAV. Fix: add the "QuickTime (Uncompressed)" Output Module format. Frames are stored as QuickTime 'raw ' samples: 8-bit RGB (depth 24, rows padded to even bytes) or ARGB with RGB + Alpha (depth 32), written through FilmCraft's existing QuickTime muxer with PCM audio (16/24-bit or float) like ProRes. Format name `uncompressed` on the control channel; disk-space estimate and Sample Format menu included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372.
Part of ranked gap #22 "Encoder efficiency" (docs/gaps.md): issue #372, "Add uncompressed single-file output" (maintainer bflatastic agreed to uncompressed RGBA in QuickTime .mov as an Output Module format). FilmCraft's QuickTime muxer (
filmcraft-isobmff, already behindcrates/export) is reused. Only therawvideo sample entry is new.Problem
The Render Queue had no single-file uncompressed output. To hand a render to your own encoder (for example ffmpeg), you had to go through a lossy codec, ProRes, or an image sequence plus a separate WAV.
Fix
OutputFormat::Uncompressed,.mov, control-channel nameuncompressed).rawsamples, following the QuickTime File Format spec (video sample description, uncompressed RGB):Mp4Writerin QuickTime mode. Audio is PCM (16/24-bit or 32-bit float, mono/stereo), the same as ProRes, and the UI's Sample Format menu now offers it for this format.bytes_per_frame) knows the exact frame size. Theformatparameter docs listuncompressed.Unsupportederror. Short frame buffers return anEncodeerror. No panics, no indexing on input-derived values.Tests
crates/export/tests/uncompressed_mov.rsuses a 33×20 comp, so 24-bit rows need padding, and a solid on a half pixel, so its edges have partial alpha:rawvideo|raw |33|20|rgb24/argb.pcm_s24le|48000|2, the sample count matches the 0.6 s span, and the RMS of ffmpeg's decode matches the sine.uncompressed.rs: row padding, ARGB ordering, the 78-byte description with depth 32, hostile sizes.render_queue.rs(project): name parsing via the Debug name the UI sends,.movstill guesses ProRes, switching from ProRes keeps the path and alpha, serde round-trip.rq_tests::without_exporternow expects 13 formats.Gates
cargo fmt --check: okcargo clippy -j 4 -p effectcraft-project -p effectcraft-export -p effectcraft-engine -p effectcraft-ui-egui --all-targets -- -D warnings: okcargo test -j 4 -p effectcraft-project -p effectcraft-export: all passcargo test -j 4 -p effectcraft-engine --no-fail-fast: all passcargo test -j 4 -p effectcraft-ui-egui --no-fail-fast: every test passes. Theui_gpubinary hits SIGSEGV at process exit after both of its tests pass. This also happens on upstream/main and is unrelated.cargo xtask layers: okcargo check -p effectcraft-project -p effectcraft-export -p effectcraft-engine --target wasm32-unknown-unknown: okcargo xtask cilocally because the machine is shared.What remains
b64a) for 16/32-bpc projects. The export pipeline currently hands movie encoders 8-bit RGBA.rawMOVs into EffectCraft: FilmCraft's media layer has norawvideo decoder yet.🤖 Generated with Claude Code