Skip to content

ci: refactor workflows to use storytold/craft-common-actions - #801

Merged
echelon merged 4 commits into
storytold:mainfrom
dylanmtaylor:refactor/dry-github-actions
Oct 11, 2026
Merged

echelon merged 4 commits into
storytold:mainfrom
dylanmtaylor:refactor/dry-github-actions

Conversation

@dylanmtaylor

@dylanmtaylor dylanmtaylor commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Refactors repetitive CI/CD workflows across EffectCraft to call centralized reusable workflows and composite actions hosted in the organization repository storytold/craft-common-actions.

Design Decisions

  • Hosted in Organization Repository: Workflows live under storytold/craft-common-actions (no personal fork/repository).
  • Intentionally Tracks @main (Not SHA Pinned): Callers deliberately track @main with an inline explanation comment so that org-wide CI improvements, security fixes, and build optimizations propagate across all 13+ craftapps automatically without requiring individual PR churn in every repository.
  • Explicit Secrets: Only the exact required signing secrets are passed explicitly (secrets: inherit is avoided).
  • Node 24 Runtimes: All composite and third-party actions inside storytold/craft-common-actions are updated to Node 24 (and pinned internally to immutable commit SHAs), eliminating Node 20 deprecation warnings.
  • Strict Verification: Build utilities like nfpm, actionlint, and trunk are verified against SHA256 checksums.
  • Preserves 100% of existing packaging, release matrix, and linting semantics for EffectCraft.

@dylanmtaylor dylanmtaylor changed the title ci: refactor workflows to use reusable artcraft-common-actions ci: refactor workflows to use storytold/craft-common-actions Oct 11, 2026
@echelon
echelon merged commit 67434e9 into storytold:main Oct 11, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants