Repository navigation
Conversation
The window opened at a fixed 1680 × 1020 wherever the system put it. Its size, position and maximized state are now saved to window.json in the config directory (when they change, and on exit) and restored on the next launch, moved onto a monitor that is still connected. The first launch fits the window to its screen. Agent-driven runs (--control) restore the saved window but don't overwrite it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The app window opened at a fixed 1680 × 1020, wherever the system put it, on every launch. Nothing saved its geometry.
Fix
apps/effectcraft/src/window.rs(ported from VectorCraft's window module, same conventions): the window's size, position and maximized state are saved towindow.jsonin the config directory, when they change (at most once a second, so a session that ends badly still has them) and on exit.--control) restore the saved window but don't overwrite it.window.jsonis ignored.winit(already in the build through eframe) becomes a dependency on every platform, not just macOS;serdeis added to the app crate.Testing
window.rs(placement, monitor changes, damaged values, tracking, save/load round trip, maximized restore): pass.EFFECTCRAFT_CONFIG_DIR: a seeded geometry (normal and maximized) is restored and tracked back unchanged; a first launch writes the fitted geometry.cargo fmt --checkandcargo clippy --workspace --all-targets --release -- -D warningspass. The rest ofcargo xtask ci(full workspace tests, layers, assets, wasm) was not run to completion locally.🤖 Generated with Claude Code