-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
fix: transfer command with proxy support #23657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
220e230 to
ae85be3
Compare
0a7c9c7 to
5f40f32
Compare
8e9fe89 to
24d6037
Compare
7735ff1 to
f45d930
Compare
f45d930 to
8c6ad6b
Compare
8c6ad6b to
2df6a32
Compare
2df6a32 to
3f4a9dc
Compare
3f4a9dc to
c658e34
Compare
|
@Bassel17 is attempting to deploy a commit to the Strapi Team on Vercel. A member of the Team first needs to authorize it. |
|
Hello thank you for this PR, |
|
Nope we don't have this inside the config. |
log errors when the transfer task faill
ex error we will be able to see when we run the transfer task:
console.error(e)
```
ProviderTransferError
at WebSocket.<anonymous> (/builds/web/cms/node_modules/
@strapi/data-transfer/dist/strapi/providers/utils.js:158:20)
at Object.onceWrapper (node:events:639:26)
at WebSocket.emit (node:events:524:28)
at WebSocket.emit (node:domain:489:12)
at emitErrorAndClose (/builds/web/cms/node_modules/ws/lib/
websocket.js:1035:13)
at ClientRequest.<anonymous> (/builds/web/cms/node_modules/
ws/lib/websocket.js:880:5)
at ClientRequest.emit (node:events:524:28)
at ClientRequest.emit (node:domain:489:12)
at emitErrorEvent (node:_http_client:101:11)
at TLSSocket.socketErrorListener (node:_http_client:504:5) {
origin: 'provider',
severity: 'fatal',
details: { step: 'transfer', details: { details: [Object] } }
}
```
console.error(e.details.details)
```
{ details: { error: '' } }
````
And the default error message we used to see: `Transfer process failed.`
8c5c120 to
84cb65b
Compare
|
okay thanks, I would encourage to setup the config with the proxy |
|
Thanks for the time effort but I don't think we will with this solution, |
Hello 👋
What does it do?
The current version of the command is unable to run inside a CI env with a proxy.
ex:
That's it, nothing else.
Why is it needed?
So we can execute the command inside an env with a proxy, ex a CI job.
How to test it?
Set a proxy, run the transfer it fails. Fixed via
sedinside my CI to validate everything.I also added to my env
GLOBAL_AGENT_ENVIRONMENT_VARIABLE_NAMESPACE: ''cf https://www.npmjs.com/package/global-agent#what-is-the-reason-global-agentbootstrap-does-not-use-http_proxyNow when it fails we will hav a few more informations:
To validate it, I have a job inside my CI to execute the command. Before calling it I added:
Related issue(s)/PR(s)
#22755
strapi/documentation#2514