- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 597
 
added ability to override federation version on export schema command #3697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            iotflowadmin
  wants to merge
  2
  commits into
  strawberry-graphql:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
iotflowadmin:federation_version_oveerride_for_export_schema
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            2 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| Release type: patch | ||
| 
     | 
||
| Added option for the export_schema command to override the output federation version. | ||
| usage example: strawberry export-schema --federation-version=2.5 | ||
| 
     | 
||
| This change ONLY affects "strawberry export-schema" command and is fully backward-compatible without any logic change. | ||
| 
     | 
||
| Warning: Please use with caution!! | ||
| 
     | 
||
| If the schema define directives that are not supported by the specified version (in the override parameter) the schema | ||
| will still generate the output using the value from the override, and may break at runtime. | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import typing | ||
| 
     | 
||
| import strawberry | ||
| from strawberry.federation.schema_directives import Key | ||
| 
     | 
||
| 
     | 
||
| @strawberry.federation.type(directives=[Key(fields="id", resolvable=False)]) | ||
| class User: | ||
| id: strawberry.ID | ||
| 
     | 
||
| 
     | 
||
| async def get_user(root: "Organization", info: strawberry.Info) -> User: | ||
| return User(id=root._owner) | ||
| 
     | 
||
| 
     | 
||
| @strawberry.federation.type(keys=["id"]) | ||
| class Organization: | ||
| id: strawberry.ID | ||
| name: str | ||
| _owner: strawberry.Private[User] | ||
| owner: User = strawberry.field(resolver=get_user) | ||
| 
     | 
||
| @classmethod | ||
| async def resolve_reference( | ||
| cls, id: strawberry.ID | ||
| ) -> typing.Optional["Organization"]: | ||
| return await get_organization_by_id(id=id) | ||
| 
     | 
||
| 
     | 
||
| async def get_organizations(): | ||
| return [ | ||
| Organization( | ||
| id=strawberry.ID("org1"), | ||
| name="iotflow", | ||
| _owner="abcdert1", | ||
| ), | ||
| Organization( | ||
| id=strawberry.ID("org2"), | ||
| name="ibrag", | ||
| _owner="abdfr2", | ||
| ), | ||
| ] | ||
| 
     | 
||
| 
     | 
||
| async def get_organization_by_id(id: strawberry.ID) -> typing.Optional[Organization]: | ||
| for organization in await get_organizations(): | ||
| if organization.id == id: | ||
| return organization | ||
| return None | ||
| 
     | 
||
| 
     | 
||
| @strawberry.type | ||
| class Query: | ||
| organizations: typing.List[Organization] = strawberry.field( | ||
| resolver=get_organizations | ||
| ) | ||
| 
     | 
||
| @strawberry.field | ||
| async def organization(self, id: strawberry.ID) -> typing.Optional[Organization]: | ||
| return await get_organization_by_id(id) | ||
| 
     | 
||
| 
     | 
||
| schema = strawberry.federation.Schema( | ||
| query=Query, types=[Organization, User], enable_federation_2=True | ||
| ) | 
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.