Skip to content

Use atomic operation to prevent deadlock when publishing in confirm mode #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RainJoe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use atomic operation to prevent deadlock when publishing in confirm mode #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions confirms.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package amqp

import "sync"
import (
"sync"
"sync/atomic"
)

// confirms resequences and notifies one or multiple publisher confirmation listeners
type confirms struct {
Expand Down Expand Up @@ -29,11 +32,7 @@ func (c *confirms) Listen(l chan Confirmation) {

// publish increments the publishing counter
func (c *confirms) Publish() uint64 {
c.m.Lock()
defer c.m.Unlock()

c.published++
return c.published
return atomic.AddUint64(&c.published, 1)
}

// confirm confirms one publishing, increments the expecting delivery tag, and
Expand Down