-
Notifications
You must be signed in to change notification settings - Fork 697
Support Jetpack Compose 1.9.4 #11877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Risky Change This is considered a risky change because it adjusts the sample app build.gradle, please review carefully. By adding the label |
9830040 to
a4ae818
Compare
|
Diffuse output: APKMANIFESTDEXARSC |
575a658 to
ca5be4d
Compare
| private fun ComposeTestRule.otpInputBox() = onNodeWithTag(OTP_ELEMENT_TAG) | ||
| .onChildAt(0) | ||
| .onChildAt(0) | ||
| .onChildAt(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change in the internal Compose basic text field. Component now nested in 3 layers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer required with new autofill changes. Setting the ContentType is now the recommended approach.
| addSpacer(id = LINK_DIVIDER_SPACER_ID, width = 0.5.em) | ||
| }.build(), | ||
| modifier = Modifier.semantics { this.invisibleToUser() }, | ||
| modifier = Modifier.semantics { this.hideFromAccessibility() }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacement for invisibleToUser
| ) | ||
| ) | ||
| ) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mitigates a Compose behavior change in which annotation links automatically add an underline text decoration now.
fca9350 to
0e41600
Compare
0e41600 to
79249ab
Compare
3 builds increased size
Stripe Identity Example 22.2.0-theme1 (20)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 🗑 android.support.v4.media.session.MediaSessionCompat | ⬇️ -55.2 kB | ⬇️ -26.5 kB |
| 📝 com.stripe.android.identity.ui.NameSectionKt | ⬆️ 29.5 kB | ⬆️ 14.2 kB |
| 📝 com.stripe.android.identity.ui.LoadingScreenKt | ⬆️ 28.8 kB | ⬆️ 13.9 kB |
| 🗑 androidx.compose.foundation.lazy.layout.LazySaveableStateHolderKt | ⬇️ -26.6 kB | ⬇️ -12.8 kB |
| 📝 com.stripe.android.identity.ui.LoadingButtonKt | ⬆️ 25.8 kB | ⬆️ 12.5 kB |
Financial Connections Example 22.2.0 (220200)
com.stripe.android.financialconnections.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 161.1 kB (1.56%)
Total download size change: ⬆️ 74.1 kB (1.6%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 🗑 com.stripe.android.ui.core.elements.MandateTextUIKt | ⬇️ -73.7 kB | ⬇️ -34.5 kB |
| 🗑 com.stripe.android.ui.core.elements.SaveForFutureUseElementUIKt | ⬇️ -67.5 kB | ⬇️ -31.6 kB |
| 🗑 com.stripe.android.ui.core.elements.H4TextKt | ⬇️ -63.2 kB | ⬇️ -29.6 kB |
| androidx.fragment.app.FragmentContainer | ⬇️ -61.9 kB | ⬇️ -29.0 kB |
| 🗑 com.stripe.android.ui.core.elements.SimpleDialogElementUIKt | ⬇️ -55.0 kB | ⬇️ -25.8 kB |
PaymentSheet Example 22.2.0 (11)
com.stripe.android.paymentsheet.example
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 226.1 kB (1.63%)
Total download size change: ⬆️ 106.4 kB (1.77%)
Largest size changes
| Item | Install Size Change | Download Size Change |
|---|---|---|
| 📝 com.nimbusds.jose.util.Base64Codec | ⬆️ 93.0 kB | ⬆️ 42.1 kB |
| 📝 com.stripe.android.financialconnections.features.common.AccountIt... | ⬆️ 69.8 kB | ⬆️ 31.6 kB |
| 📝 com.nimbusds.jose.util.IntegerUtils | ⬆️ 69.6 kB | ⬆️ 31.5 kB |
| 🗑 com.stripe.android.uicore.elements.bottomsheet.StripeBottomSheetS... | ⬇️ -62.3 kB | ⬇️ -28.2 kB |
| kotlin.comparisons.ComparisonsKt | ⬆️ 64.6 kB | ⬆️ 27.8 kB |
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded



Summary
Support Jetpack Compose 1.9.4
Motivation
Keep Jetpack Compose up to date.
Testing