Fix account onboarding from PR 2087 #2187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maragues-stripe
requested changes
Oct 28, 2025
maragues-stripe
left a comment
maragues-stripe
left a comment
There was a problem hiding this comment.
Thanks!
I reviewed the android files, some of which were written by me.
There was a problem hiding this comment.
Let's cleanup logs in this file. I don't think they are valuable.
There was a problem hiding this comment.
Let's cleanup all logs in this file, and the log function. I don't think they are valuable.
There was a problem hiding this comment.
Same. Please cleanup logs, unless @gimenete-stripe wants to keep some of them.
| promise: Promise, | ||
| ) { | ||
| getCurrentActivityOrResolveWithError(promise)?.let { activity -> | ||
| UiThreadUtil.runOnUiThread { |
There was a problem hiding this comment.
Does this whole block need to run on UI thread? Or maybe only accountOnboardingController.show()?
… on UI thread only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2087 addressing Guido's review comments by removing the unused AccountOnboarding client secret wiring across TS, iOS, Android, and the example app.