fix: rework API to support injecting providers into Factory (fixes #9) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertrossmann
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9
The problem was that wrapping the dataloader Factory into a Nest.js sub-module caused that module to not have access to the parent's providers, thus dependency injection did not work. To complement the problem, it looks like vitest uses
esbuildunder the hood which does not support emitting decorator metadata which in turn caused Nest.js to not be able to properly find the referenced providers (because it needs that metadata).I changed the API for registering dataloader Factory (see the updated README) and adopted
swcas the vitest compiler.