restricted volume and issue to positive integers only :)#8
Open
AuroraAustralis7 wants to merge 1 commit into
Open
restricted volume and issue to positive integers only :)#8AuroraAustralis7 wants to merge 1 commit into
AuroraAustralis7 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates server dependencies/node tooling and improves draft creation UI/text formatting.
Changes:
- Adds new dependencies and bumps
nodemonin the serverpackage.json. - Adjusts HTML post-processing to attempt to preserve paragraph indentation.
- Adds
min={1}constraints to volume/issue numeric inputs.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| server/package.json | Dependency/tooling updates for the server runtime/dev workflow |
| client/src/routes/create_draft/create_draft.tsx | Draft HTML normalization + numeric input constraints |
Files not reviewed (1)
- server/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "jsonwebtoken": "^8.5.1", | ||
| "mongoose": "^6.7.2", | ||
| "morgan": "^1.10.0", | ||
| "node": "^24.16.0", |
| let text: string = String(html); | ||
| text = text.replace(new RegExp("<p></p>", "g"), ""); // remove breaks between paragraphs | ||
| text = text.replace(new RegExp("\n", "g"), ""); // remove line breaks in the html | ||
| text = text.replace(/(<p[^>]*>)\s+/g, "$1	"); // replace indents |
Comment on lines
+104
to
+106
| <input type="number" id="new_volume" min={1}/> | ||
| | Issue: | ||
| <input type="number" id="new_issue" /> | ||
| <input type="number" id="new_issue" min={1}/> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also tried to make the text box replace whitespace but not sure if it works