Skip to content

Conversation

@nielspardon
Copy link
Member

I noticed there are multiple gaps in the serialization and deserialization of `AdvancedExtension which I'm trying to close with this PR:

  • in PlanProtoConverter pass ExtensionProtoConverter to RelProtoConverter
  • in ProtoPlanConverter pass ProtoExtensionConverter to ProtoRelConverter
  • move/add HasExtension interface to AbstractDdlRel, AbstractWriteRel
  • add missing serde logic for relations to RelProtoConverter, ProtoRelConverter
  • adds a test that confirms the extension converters are passed through from plan converters to rel converters

@nielspardon
Copy link
Member Author

nielspardon commented Oct 24, 2025

I'm working on adding more tests to verify the serialization/deserialization for each relation type

@nielspardon nielspardon marked this pull request as draft October 24, 2025 07:35
@nielspardon nielspardon marked this pull request as ready for review October 24, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant