Trigger game over when any column reaches the top#44
Trigger game over when any column reaches the top#44AliHassan245 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
- The original game-over logic only checked if the middle column was full, allowing side to be ignored. - This update adds a check on the top row of the grid after line clearing. If any cell in the top row is filled, the game immediately transitions to the GAME_OVER state, aligning the behavior with standard Tetris mechanics.
|
James and Ibiam my previous PR got accidently closed when I was trying to update commit message. Alternatively I opened this PR and have used proper git messages. Thanks so much for your understanding! This PR is all set and ready to go! 🚀 |
|
Thanks, the commit message is much improved, and it lets me see what you intend. But I've no wish to align with standard Tetris game mechanics. I'm fine with fixing any regressions since Vadim Gerasimov wrote the code. This git repository has the history back to only version 7 of the activity, Before that version, the git repository is at http://dev.laptop.org/git/projects/block-party-activity/ rendered using cgit and can be cloned with I'd like this older history to be added to this repository, but that's a maintainer task you may not be able to do. If you can demonstrate from the complete history or one of the original commits that the game mechanics have regressed, then I'm interested in getting it fixed. Children don't need games to behave the same. The concept of rules negotiation is well understood by most children, and where it is not understood development is not helped by making everything the same. |
|
Quzol I checked the history, there is no regression in game mechanics, and the middle-column game-over logic matches Vadim’s original code. My suggestion was more from a gameplay clarity perspective. In an 11-column grid, it can be a bit hard for players to visually identify the exact middle column while blocks are falling. Allowing game-over to trigger on any column could make the end condition more visually clearer and intutive for players. That said, I’m happy to keep the original behavior if consistency with Vadim’s version is preferred. Just wanted to point out this potential usability improvement. |
|
Thanks for checking. Don't see why it would be visually clearer and intuitive. I'm fine with the behaviour of the game without your change. So my vote is no. If any other developers would like to pipe up, please do. |
|
Thanks for reviewing, quozl. Since you invited others to share thoughts, tagging @chimosky as well. |
2 participants
No description provided.