update facet drawer height

[dnoneill]

closes #6229

[taylor-steve]

I think @dbranchini may have intentionally added the close button in the larger design?

[dnoneill]

@taylor-steve Thanks I missed that. I am assuming this should look the same on medium screens as well?

[taylor-steve]

Is medium the full size side drawer? That seems fine to me but Darcy would the one to say for sure.

[dnoneill]

done and screenshots added

[taylor-steve]

Should the headings be h1? We've got a visually-hidden h1 right above it. Site improve thinks it's fine, WAVE doesn't like it. I don't know if drawers have special considerations?

[dbranchini]

Per SODA, WAVE complains with more false positives than the other scanning tools because it scans hidden elements. We should use the same pattern here as we do for modals, and we use H2s for modals.

As far as medium sized, this is what I designed and it seems that was implemented, so we shouldn't have drawers on that size.

[dnoneill]

@taylor-steve I went with a h1 because the top filters and other filters headings are h2 so it seemed weird to make it the same level heading when semantically it isn't.

[jcoyne]

Can @dbranchini review this? It seems like she's asked for h2s but you thought h1s better.

[dbranchini]

H2's is what we use on modals too, it should be an H2. (@alundgard and I discussed this a while back, it's a gray area for both drawers and modals, but we decided on H2s.)

[dnoneill]

@taylor-steve ready for review. We removed the "filters" header based on talking to Darcy because in order to get the filters into a h2 we would have had to put the top filters and other filters into a h3 which would have been a pain.