-
Notifications
You must be signed in to change notification settings - Fork 0
Adds VMA preprocessing tasks #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shelleydoljack
wants to merge
8
commits into
main
Choose a base branch
from
t1666-vma-preprocessing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jermnelson
approved these changes
Dec 18, 2025
Collaborator
jermnelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Contributor
Author
7fa3daf to
4db3001
Compare
Contributor
Author
|
Fixed the issue with rendering interfaces that caused the error above with this commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Closes #1666
Cleans up some outdated code.
Adds tests for verifying data structure saved to VendorInterface record from form data.
Adds ability to prepend data to the 001 field.
Adds ability to add a subfield to an existing field, given a pattern match in the existing field's specified subfield, or simply add it to existing field regardless.
Vendor Interface view:

Vendor Interface edit view:

I didn't address the fact that the default_data_processor DAG has some hardcoded stuff in it (like remove fields 905, 920, 986 or add field 910 if data is entered in the package name). I also didn't add code to allow users to add a field (not sure if that is a desired feature).