Dag and plugins to update reading room patron permissions #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shelleydoljack
left a comment
shelleydoljack
left a comment
There was a problem hiding this comment.
Looks good. I think it'd be good to break up the tasks into mapped tasks so that retries happen for one user instead of a whole list of users. It might make dealing with failures easier.
jermnelson
requested changes
Jan 6, 2026
shelleydoljack
approved these changes
Jan 6, 2026
Contributor
shelleydoljack
left a comment
shelleydoljack
left a comment
There was a problem hiding this comment.
Just one suggestion to change formatting datetime objects.
jgreben
force-pushed
the
reading-room
branch
2 times, most recently
from
d437813 to
20c934b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadingRoomsDataclass contains all of the existing reading room permissions and usergroup lookups needed for the FolioUser being updated.