fix(splitter): improve EOF handling #556
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you type
select case
in a file, the LSP will crash.The reason is that we forgot to handle the EOF token in the
case()
function in the splitter.I feel that, since we deal with incomplete statements all the time, it's better to bubble up an Err if we reach EOF:
But it's a bit invasive, so WDYT?
(Pretty sure this fixes #540, it's the same kind of error)