Support max_rows directive on table and view #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kafaichoi
changed the title
kafaichoi
force-pushed
the
support-max-rows-in-table-and-view
branch
from
59ca910 to
50ad0f5
Compare
imor
approved these changes
Jun 13, 2025
|
Thanks for your work on this feature ! 😘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
max_rows directive on table and view will be enforced. (precedence as table/view > schema)
Closes #594
What is the current behavior?
max_rows directives on table and view are ignored.
What is the new behavior?
max_rows directive on table & view will be enforced just like max_rows on schema.