Skip to content

Conversation

wesharper
Copy link

What kind of change does this PR introduce?

  • upgrade pg_graphql from v1.5.7 to v1.5.8

Additional context

The patch to pg_graphql is backwards compatible.

Action Items

  • New extension releases were Checked for any breaking changes
  • Extensions compatibility Checked
  • Backup and Restore Checked
    • Proceed to backup testing while extensions are enabled
      • After every restore, re-run the tests specified at point 3.1

Extensions compatibility testing

  1. Enable every extension
    1. Check Postgres’ log output for any error messages while doing so
      1. This might unearth incompatibilities due to unsupported internal functions, missing libraries, or missing permissions
  2. Disable every extension
    1. Check Postgres’ log output for any cleanup-related error messages
  3. Re-enable each extension
    1. Run basic tests against the features they offer, e.g.:
      1. pg_net - execute HTTP requests
      2. pg_graphql - execute queries and mutations
      3. …to be filled in

Backup Testing

Follow the testing steps steps for all the following cases:

  • Pause on new Postgres version, restore on new Postgres version
  • Pause on older Postgres version, restore on new Postgres version
  • Run a single-file backup backup, restore the backup

Testing steps

  1. Generate dummy data
    • the ‘Countries’ or ‘Slack clone’ SQL editor snippets are decent datasets to work with, albeit limited
  2. Save a db stats snapshot file
    • Do this by running supa db-stats gather -p <project_ref>
  3. Backup the database, through pausing the project, or otherwise
  4. Restore the backup, through unpausing the project or cli
  5. Check the data has been recovered successfully
    1. Visual checks/navigating through the tables works
    2. Run supa db-stats verify against the project and the previously saved file

@wesharper
Copy link
Author

wesharper commented Sep 26, 2024

pg_graphql is getting bumped to v1.5.8 in this PR

@wesharper
Copy link
Author

wesharper commented Sep 26, 2024

Since the actual package hasn't been released yet, this will remain in draft until the package is released and tested.

@wesharper wesharper changed the title pg_graphql extension bump Upgrade pg_graphql to 1.5.8 Sep 26, 2024
@wesharper
Copy link
Author

wesharper commented Sep 26, 2024

Need guidance on how to get sha-256 hashes for github and cargo.

@wesharper wesharper marked this pull request as ready for review September 26, 2024 20:17
@wesharper wesharper requested review from a team as code owners September 26, 2024 20:17
@olirice
Copy link
Contributor

olirice commented Sep 26, 2024

I'm going to close this PR as its going to take more than usual to bump the pg_graphql version

We bumped the version of pgrx that pg_graphql depends on to get Postgres 17 support and we don't have pgrx version 0.12.4 supported in our nix tooling yet.

We're highly motivated to get this updated though because its blocking our release of pg17. I'd expect it to be merged sometime next week which would get the updated version available to you ~ Oct 8

@olirice olirice closed this Sep 26, 2024
@wesharper
Copy link
Author

No worries at all, thanks for all your help @olirice.

@wesharper wesharper deleted the pg_graphql/bump/1.5.8 branch September 27, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants