fix(release): add version to microsandbox-utils build-dep#662
Merged
Conversation
cargo publish requires every dependency entry — including build-dependencies — to specify a version. The microsandbox crate's build-dep on microsandbox-utils was path-only, which caused the crates-publish job to fail for v0.4.4 with: all dependencies must have a version requirement specified when publishing. dependency `microsandbox-utils` does not specify a version Match the runtime dep shape by adding version = "0.4.4" alongside the path so the manifest verifies and the crate publishes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The
microsandboxcrate failed to publish on the v0.4.4 release because its build-dependency onmicrosandbox-utilswas path-only. This adds the missingversionfield socargo publishaccepts the manifest.Description
cargo publishrequires every dependency entry, including build-dependencies, to specify a version.microsandbox-utilsalready hadversion = "0.4.4", but the[build-dependencies]entry was path-only and tripped manifest verification.microsandboxstep incrates-publishwith:dependency 'microsandbox-utils' does not specify a version.cargo publish -p microsandbox --dry-run --no-verifynow passes manifest verification locally.Test Plan
cargo publish -p microsandbox --dry-run --no-verifyreaches the upload step without manifest errorscrates-publishjob to completion past themicrosandboxcrate