feat: Experimental plugin support [v0.50.0] #909
Conversation
…method and enhance error handling for plugin version mismatches and duplicates
# Conflicts: # lib/build/emailpassword.js # lib/build/emailverification.js # lib/build/genericComponentOverrideContext.js # lib/build/index.js # lib/build/multifactorauth.js # lib/build/multitenancy.js # lib/build/oauth2provider.js # lib/build/passwordless.js # lib/build/passwordlessprebuiltui.js # lib/build/session.js # lib/build/thirdparty.js # lib/build/totp.js # lib/build/version.d.ts # lib/ts/version.ts # package-lock.json # package.json
# Conflicts: # lib/build/emailpassword-shared5.js # lib/build/genericComponentOverrideContext.js # lib/build/utils.d.ts # lib/ts/utils.ts # package-lock.json # package.json
feat: Add init method support, better support for dynamic route handlers and added support for exporting logic from plugins
coolbueb
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| return React.useContext(genericContext); | ||
| const contextValue = React.useContext(genericContext); | ||
|
|
||
| return { ...SuperTokens.getInstance()?.componentOverrides[key], ...contextValue }; |
There was a problem hiding this comment.
The code accesses componentOverrides[key] on the result of SuperTokens.getInstance(), which may return undefined. This creates a potential null reference exception when SuperTokens hasn't been initialized yet. Consider using SuperTokens.getInstanceOrThrow() instead, or add null checking with optional chaining:
return { ...(SuperTokens.getInstance()?.componentOverrides[key] || {}), ...contextValue };This ensures the code handles the case when SuperTokens isn't initialized without throwing runtime errors.
| return { ...SuperTokens.getInstance()?.componentOverrides[key], ...contextValue }; | |
| return { ...(SuperTokens.getInstance()?.componentOverrides[key] || {}), ...contextValue }; |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| @@ -87,7 +86,6 @@ export default class Passwordless extends AuthRecipe< | |||
| public readonly webJSRecipe: WebJSRecipeInterface<typeof PasswordlessWebJS> = PasswordlessWebJS | |||
| ) { | |||
| super(config); | |||
| this.recipeID = config.recipeId; | |||
|
|
|||
| PostSuperTokensInitCallbacks.addPostInitCallback(() => { | |||
There was a problem hiding this comment.
Potential Bug: The line this.recipeID = config.recipeId; was removed, which might affect recipe identification. The recipeID property is declared in the base class and may need to be explicitly set from the config. Consider verifying that removing this assignment doesn't break the recipe identification logic, especially if there are cases where the static RECIPE_ID value isn't sufficient.
| PostSuperTokensInitCallbacks.addPostInitCallback(() => { | |
| PostSuperTokensInitCallbacks.addPostInitCallback(() => { | |
| this.recipeID = config.recipeId; |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
…egisterCredentialWithUser` method for user-specific credential registration
…base # Conflicts: # lib/build/webauthn.js
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.someFunc: function () {..}).size-limitsection ofpackage.jsonwith the size limit set to the current size rounded up.rollup.config.mjslib/ts/types.tslib/ts/recipe/multifactorauth/types.tsRemaining TODOs for this PR