feat: adds dev/release tag pipelines #911
Conversation
- Sets up dev/release tag pipelines - Adds script to populate common constants - Updates workflows to run on PRs and dev-tags
size-limit report 📦
|
- Ensures chromatic statuses are checked in the release checks
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| exit 1 | ||
| fi | ||
|
|
||
| if [[ "${{ steps.versions.outputs.packageVersion }}" != ${{ inputs.branch }}* ]] |
There was a problem hiding this comment.
The branch comparison has a quoting issue that could lead to shell interpretation problems. The right side of the comparison should be quoted:
if [[ "${{ steps.versions.outputs.packageVersion }}" != "${{ inputs.branch }}"* ]]This ensures that any special characters in the branch name are treated as literals rather than being interpreted by the shell.
| if [[ "${{ steps.versions.outputs.packageVersion }}" != ${{ inputs.branch }}* ]] | |
| if [[ "${{ steps.versions.outputs.packageVersion }}" != "${{ inputs.branch }}"* ]] |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| - name: Populate variables | ||
| id: versions | ||
| run: | | ||
| . ./hooks/populate-hook-constants.sh |
There was a problem hiding this comment.
Consider adding a step to ensure the script is executable before sourcing it:
chmod +x ./hooks/populate-hook-constants.sh
. ./hooks/populate-hook-constants.shThis prevents potential permission issues after checkout, as Git doesn't always preserve executable permissions across systems.
| . ./hooks/populate-hook-constants.sh | |
| chmod +x ./hooks/populate-hook-constants.sh | |
| . ./hooks/populate-hook-constants.sh |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| import httpx | ||
| import sys | ||
|
|
||
| check_runs_url = "https://api.github.com/repos/${{ github.repository }}/commits/tags/${{ needs.setup.outputs.devTag }}/check-runs?per_page=100&page={page}" |
There was a problem hiding this comment.
The URL format for GitHub's API check runs endpoint appears incorrect. The path segment tags/ in commits/tags/${{ needs.setup.outputs.devTag }} is not standard GitHub API syntax. Consider using one of these formats instead:
https://api.github.com/repos/${{ github.repository }}/commits/${{ needs.setup.outputs.devTag }}/check-runs
or
https://api.github.com/repos/${{ github.repository }}/commits/refs/tags/${{ needs.setup.outputs.devTag }}/check-runs
GitHub's API documentation can provide further guidance on the correct format.
| check_runs_url = "https://api.github.com/repos/${{ github.repository }}/commits/tags/${{ needs.setup.outputs.devTag }}/check-runs?per_page=100&page={page}" | |
| check_runs_url = "https://api.github.com/repos/${{ github.repository }}/commits/refs/tags/${{ needs.setup.outputs.devTag }}/check-runs?per_page=100&page={page}" |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.someFunc: function () {..}).size-limitsection ofpackage.jsonwith the size limit set to the current size rounded up.rollup.config.mjslib/ts/types.tslib/ts/recipe/multifactorauth/types.tsRemaining TODOs for this PR