Skip to content

Conversation

@namsnath
Copy link
Contributor

@namsnath namsnath commented Mar 14, 2025

Summary of change

  • Sets up workflow to run auth-react tests
    • Updates test-servers to work with updated tests

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

@namsnath namsnath self-assigned this Mar 14, 2025
@namsnath namsnath requested a review from porcellus March 14, 2025 14:16
@namsnath namsnath marked this pull request as ready for review April 14, 2025 09:20
@promptless
Copy link

promptless bot commented Apr 14, 2025

📝 Documentation updates detected! You can review documentation updates here

@namsnath namsnath force-pushed the ci/github-actions/auth-react branch 2 times, most recently from f6eb753 to 4ca718d Compare April 16, 2025 12:12
@namsnath
Copy link
Contributor Author

Closing/reopening to trigger test re-runs

@namsnath namsnath closed this Apr 22, 2025
@namsnath namsnath reopened this Apr 22, 2025
- Sets up workflow to run auth-react tests
  - Updates test-servers to work with updated tests
@namsnath namsnath force-pushed the ci/github-actions/auth-react branch from 52042af to a0fde43 Compare April 22, 2025 10:35
@namsnath namsnath merged commit 6529f65 into 0.29 May 1, 2025
1576 of 1577 checks passed
@namsnath namsnath deleted the ci/github-actions/auth-react branch May 1, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants