Skip to content

Conversation

namsnath
Copy link
Contributor

@namsnath namsnath commented Aug 7, 2025

  • Moves is_recipe_initialized to supertokens.asyncio
  • Cleans up supertokens init file to reduce redundancy
  • Adds test to ensure FactorIds class and method are in sync

ref: supertokens/supertokens-node#1021

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

@namsnath namsnath self-assigned this Aug 7, 2025
@namsnath namsnath requested review from sattvikc and porcellus August 11, 2025 07:11
@namsnath namsnath requested a review from porcellus August 20, 2025 12:38
Base automatically changed from feat/plugin/experiment to 0.31 August 21, 2025 12:17
@namsnath namsnath force-pushed the feat/mfa/get-available-first-factors branch from 8b72626 to 7f0b1a9 Compare August 21, 2025 12:46
- Moves is_recipe_initialized to supertokens.asyncio
- Cleans up supertokens __init__ file to reduce redundancy
- Adds test to ensure FactorIds class and method are in sync

ref: supertokens/supertokens-node#1021
@namsnath namsnath force-pushed the feat/mfa/get-available-first-factors branch from 7f0b1a9 to 2365468 Compare August 21, 2025 12:47
@namsnath namsnath merged commit b783a65 into 0.31 Aug 21, 2025
15 of 205 checks passed
@namsnath namsnath deleted the feat/mfa/get-available-first-factors branch August 21, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants