feat: add sr_clone() for shared-runtime independent sessions#14
Open
Adamkaram wants to merge 1 commit intosurrealdb:mainfrom
Open
feat: add sr_clone() for shared-runtime independent sessions#14Adamkaram wants to merge 1 commit intosurrealdb:mainfrom
Adamkaram wants to merge 1 commit intosurrealdb:mainfrom
Conversation
Add sr_clone() function that creates an independent Surreal handle sharing the same underlying database engine as the original connection. Uses Arc<Runtime> to share the Tokio runtime across all clones — zero memory overhead per clone. This enables multiple concurrent sessions on a single embedded (surrealkv://) connection without file locking issues. Each clone has its own namespace/database state set via sr_use_ns/sr_use_db. Changes: - Change Surreal.rt from Runtime to Arc<Runtime> - Add sr_clone() C FFI function with full safety docs - Update surrealdb.h with sr_clone declaration - Clean up enum/comment formatting in surrealdb.h Use case: Multi-tenant WhatsApp service with thousands of instances sharing one surrealkv file. Each instance gets an sr_clone() with independent NS/DB state. Benchmark: 17,111 q/s (20K concurrent queries across 10 clones) vs 7,577 q/s shared connection.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.
Once credits are available, reopen this pull request to trigger a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sr_clone() function that creates an independent Surreal handle sharing the same underlying database engine as the original connection. Uses Arc to share the Tokio runtime across all clones — zero memory overhead per clone.
This enables multiple concurrent sessions on a single embedded (surrealkv://) connection without file locking issues. Each clone has its own namespace/database state set via sr_use_ns/sr_use_db.
Changes:
Use case: Multi-tenant WhatsApp service with thousands of instances sharing one surrealkv file. Each instance gets an sr_clone() with independent NS/DB state. Benchmark: 17,111 q/s (20K concurrent queries across 10 clones) vs 7,577 q/s shared connection.