Skip to content

Cleanup and update dependencies#387

Open
WolfieLeader wants to merge 3 commits intosurrealdb:mainfrom
WolfieLeader:refactor-cleanup-and-update-deps
Open

Cleanup and update dependencies#387
WolfieLeader wants to merge 3 commits intosurrealdb:mainfrom
WolfieLeader:refactor-cleanup-and-update-deps

Conversation

@WolfieLeader
Copy link

Summary

Housekeeping: remove a stale config backup and bump two outdated dependencies.

Commits

  1. Remove .golangci.bck.yml — leftover from golangci-lint v1→v2 migration, references deprecated linters (exportloopref, gomnd), unreferenced by any workflow or Makefile
  2. Bump fxamacker/cbor/v2 v2.7.0→v2.9.0 — adds opt-in TextMarshaler/JSON transcoding, omitzero struct tag. No API changes; all EncMode/DecMode/TagSet/RawMessage usage unchanged
  3. Bump stretchr/testify v1.8.4→v1.10.0 — test-only dep, adds new assertion helpers (NotElementsMatch, NotErrorAs, in-order mock validation). No breaking changes

Compatibility

  • No source code changes required for either dependency bump
  • Go minimum unchanged at 1.23 (cbor v2.8+ needs 1.20, testify needs 1.17)
  • Tested with both surrealcbor and fxamackercbor codec paths

Testing

  • make lint — 0 issues
  • make build — compiles cleanly
  • make test — passes with all codec/connection combinations

Leftover backup from the golangci-lint v1 to v2 config migration.
References deprecated linters (exportloopref, gomnd) and uses the
v1 config format. No workflow or Makefile references this file.
v2.9.0 adds opt-in TextMarshaler/TextUnmarshaler and JSON
transcoding support. v2.8.0 added omitzero struct tag option.
No breaking API changes; RawMessage, EncMode, DecMode, TagSet
usage remains compatible. Minimum Go moved to 1.20 (repo: 1.23).
Test-only dependency. v1.10.0 adds NotElementsMatch, NotErrorAs,
in-order mock validation. v1.9.0 added NotImplements, EventuallyWithT.
No breaking changes; minimum Go 1.17.
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.

Once credits are available, reopen this pull request to trigger a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant