ci: apple & android targets for CI matrix#369
Conversation
|
Thank you @itsezc |
|
@arriqaaq looks like we have to move to nightly builds for Rust as some of these platforms are tier 3 in rust, is this something you're open to? I've tested SurrealKV built locally on tvOS and watchOS and it builds but not able to run as theres inadequate resources. We can remove |
|
Hey @itsezc Firstly, thank you for the suggestion. My thoughts are that the main CI pipeline should reflect the platforms we officially support and guarantee to build on stable Rust. If some of the newer Apple targets (for example visionOS) are currently Tier 3 in Rust, how about we not make nightly Rust or experimental targets a requirement for all contributors? Can we instead:
This way:
Let me know your thoughts |
|
Hi, that makes alot of sense and keeps contributors happy too! |
|
@arriqaaq theres a few target OS that aren't handled in one of the dependencies (fs2), I'd like to patch this via vendoring on Cargo, does this work for you? The crate hasn't been updated in what seems to be for 9 years, so contributing is a bit out of reach, hence my suggestion. |
|
Hey @itsezc Sorry for the delayed response. Please feel free to make changes in the PR, will have a look and will discuss with you and we can look into getting it merged |
Closes #368
Minor change to the CI matrix to ensure SurrealKV builds for Apple (iOS, watchOS, tvOS, visionOS) & Android platforms