Repository navigation
chore(license): copy root LICENSE file - #2582
angelOlivares merged 1 commit into
Conversation
c333b0b to
88e6f3b
Compare
Makes sense!! Thanks!!! |
bitflicker64
left a comment
bitflicker64
left a comment
There was a problem hiding this comment.
Following up on my earlier comment: the reuse lint-file pre-commit hook fails here. All 150 Go files report "missing license Apache-2.0", because their SPDX-License-Identifier: Apache-2.0 headers need the text at LICENSES/Apache-2.0.txt.
Could you copy the file to LICENSE instead of moving it, so both exist? REUSE ignores files named LICENSE, so lint stays green, and GitHub still detects Apache-2.0 at the root. git checkout origin/main -- LICENSES/Apache-2.0.txt restores the original. The commit and PR title would then need a small update too, since it no longer moves the file.
Signed-off-by: angelOlivares <olivares.angelp@gmail.com>
88e6f3b to
84bf9ae
Compare
angelOlivares
changed the title
bitflicker64
left a comment
bitflicker64
left a comment
There was a problem hiding this comment.
Thanks for the quick fix. LGTM.
2 participants
Hi everyone, the reason why we showed up as this repo without a license is because it was "a bit hidden". Not at root level, hence not recognized.
Thanks!